Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix ignored selection key setting when candidate per page is less than 10 #247

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

kanru
Copy link
Member

@kanru kanru commented Feb 12, 2025

libchewing API document says

selkeys is an ASCII code integer array of length MAX_SELKEY. The second argument is unused.

However, it actually resets the selkey to default if any length that is not 10 is passed. Fixing the API is more dangerous because we might accidentally read pass end of array passed in. So fixing in ibus-chewing instead.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.29%. Comparing base (208867a) to head (7b1652e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #247   +/-   ##
=======================================
  Coverage   52.29%   52.29%           
=======================================
  Files          17       17           
  Lines        2096     2096           
=======================================
  Hits         1096     1096           
  Misses       1000     1000           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanru kanru added this to the 2.1.4 milestone Feb 12, 2025
@kanru kanru merged commit f30bb8a into master Feb 12, 2025
5 checks passed
@kanru kanru deleted the fix-set-selkey-len branch February 12, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant