refactor: replace GoDotLog with Chickensoft.Log

Chickensoft.GoDotTest.Tests/Chickensoft.GoDotTest.Tests.csproj

@@ -1,8 +1,7 @@
 <Project Sdk="Godot.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>net6.0</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
     <EnableDynamicLoading>true</EnableDynamicLoading>
-    <LangVersion>10.0</LangVersion>
     <Nullable>enable</Nullable>
     <RootNamespace>Chickensoft.GoDotTest.Tests</RootNamespace>
     <!-- Required for some nuget packages to work -->

Chickensoft.GoDotTest.Tests/Properties/launchSettings.json

@@ -0,0 +1,10 @@
+{
+  "profiles": {
+    "Debug Tests": {
+      "commandName": "Executable",
+      "executablePath": "%GODOT4%",
+      "commandLineArgs": "--run-tests --listen-trace --quit-on-finish",
+      "workingDirectory": "."
+    }
+  }
+}

Chickensoft.GoDotTest.Tests/test/src/GoTestTest.cs

@@ -2,10 +2,11 @@ namespace Chickensoft.GoDotTest.Tests;
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Reflection;
 using System.Threading.Tasks;
+using Chickensoft.Log;
 using Godot;
-using GoDotLog;
 using GoDotTest;
 using LightMock;
 using LightMock.Generator;
@@ -40,7 +41,7 @@ public GoTestTest(Node testScene) : base(testScene) { }
   public async Task DoesNothingIfNotRunningTests() {
     var adapter = new Mock<TestAdapter>();
     GoTest.Adapter = adapter.Object;
-    var testEnv = TestEnvironment.From(Array.Empty<string>());
+    var testEnv = TestEnvironment.From([]);
     var log = new Mock<ILog>();
     var assembly = Assembly.GetExecutingAssembly();
     await GoTest.RunTests(assembly, TestScene, testEnv, log.Object);
@@ -49,7 +50,7 @@ public async Task DoesNothingIfNotRunningTests() {
   [Test]
   public async Task ExitsWithFailingExitCodeWhenTestsFail() {
     var testEnv = TestEnvironment.From(
-      new string[] { "--run-tests=ahem", "--quit-on-finish" }
+      ["--run-tests=ahem", "--quit-on-finish"]
     );
     var log = new Mock<ILog>();
     var provider = new Mock<ITestProvider>();
@@ -66,10 +67,36 @@ await GoTest.RunTests(
     provider.VerifyAll();
   }
 
+  [Test]
+  public async Task RemovesTraceListenerWhenTestsFail() {
+    // will be 1 in VSCode, 2 in VS (it adds its own DefaultTraceListener
+    // to run these tests)
+    var traceListenerCount = Trace.Listeners.Count;
+    var testEnv = TestEnvironment.From(
+      [
+        "--run-tests=ahem",
+        "--listen-trace",
+         "--quit-on-finish"
+      ]
+    );
+    var log = new Mock<ILog>();
+    var provider = new Mock<ITestProvider>();
+
+    SetupTest(testEnv, log, provider);
+
+    int? testExitCode = null;
+    GoTest.OnExit = (node, exitCode) => testExitCode = exitCode;
+
+    await GoTest.RunTests(
+      Assembly.GetExecutingAssembly(), TestScene, testEnv, log.Object
+    );
+    Trace.Listeners.Count.ShouldBe(traceListenerCount);
+  }
+
   [Test]
   public async Task ExitsWithFailingExitCodeWhenTestsFailOnCoverage() {
     var testEnv = TestEnvironment.From(
-      new string[] { "--run-tests=ahem", "--coverage", "--quit-on-finish" }
+      ["--run-tests=ahem", "--coverage", "--quit-on-finish"]
     );
     var log = new Mock<ILog>();
     var provider = new Mock<ITestProvider>();
@@ -88,7 +115,7 @@ await GoTest.RunTests(
   [Test]
   public async Task TimeoutMillisecondSetterShouldHaveAnImpactWhenCreatingExecutor() {
     var testEnv = TestEnvironment.From(
-      new string[] { "--run-tests=ahem", "--coverage", "--quit-on-finish" }
+      ["--run-tests=ahem", "--coverage", "--quit-on-finish"]
     );
     var log = new Mock<ILog>();
     var provider = new Mock<ITestProvider>();
@@ -108,7 +135,7 @@ private void SetupTest(TestEnvironment testEnv, Mock<ILog> log, Mock<ITestProvid
     provider
           .Setup(provider => provider.GetTestSuitesByPattern(
             The<Assembly>.IsAnyValue, "ahem"
-          )).Returns(new List<ITestSuite>());
+          )).Returns([]);
 
     var reporter = new Mock<ITestReporter>();
     reporter.Setup(reporter => reporter.HadError).Returns(true);

Chickensoft.GoDotTest.Tests/test/src/TestAdapterTest.cs

@@ -1,7 +1,7 @@
 namespace Chickensoft.GoDotTest.Tests;
 
+using Chickensoft.Log;
 using Godot;
-using GoDotLog;
 using GoDotTest;
 using LightMock.Generator;
 using Shouldly;

Chickensoft.GoDotTest.Tests/test/src/TestEnvironmentTest.cs

@@ -9,22 +9,24 @@ public TestEnvironmentTest(Node testScene) : base(testScene) { }
 
   [Test]
   public void ConstructsTestEnvironmentWithPatternFlag() {
-    var testEnvironment = TestEnvironment.From(new string[] {
+    var testEnvironment = TestEnvironment.From([
       "--run-tests=SomeTest"
-    });
+    ]);
     testEnvironment.TestPatternToRun.ShouldBe("SomeTest");
   }
 
   [Test]
   public void ConstructsTestEnvironmentWithSimpleFlags() {
     var args = new string[] {
       "--quit-on-finish",
-       "--stop-on-error",
-       "--sequential",
-       "--coverage",
+      "--listen-trace",
+      "--stop-on-error",
+      "--sequential",
+      "--coverage",
     };
     var testEnvironment = TestEnvironment.From(args);
     testEnvironment.QuitOnFinish.ShouldBeTrue();
+    testEnvironment.ListenTrace.ShouldBeTrue();
     testEnvironment.StopOnError.ShouldBeTrue();
     testEnvironment.Sequential.ShouldBeTrue();
     testEnvironment.Coverage.ShouldBeTrue();