Merge pull request #1 from chickensoft-games/dry-logs

Improve code repetition
chickensoft-games · Jan 29, 2025 · c6c74b6 · c6c74b6
2 parents 7e2fc2f + 59a3023
commit c6c74b6
Show file tree

Hide file tree

Showing 23 changed files with 682 additions and 1,521 deletions.
diff --git a/Chickensoft.Log.Tests/badges/branch_coverage.svg b/Chickensoft.Log.Tests/badges/branch_coverage.svg
diff --git a/Chickensoft.Log.Tests/badges/line_coverage.svg b/Chickensoft.Log.Tests/badges/line_coverage.svg
diff --git a/Chickensoft.Log.Tests/test/src/ConsoleLogTest.cs b/Chickensoft.Log.Tests/test/src/ConsoleLogTest.cs
diff --git a/Chickensoft.Log.Tests/test/src/LogFormatterTest.cs b/Chickensoft.Log.Tests/test/src/LogFormatterTest.cs
@@ -22,6 +22,39 @@ public void FormatsMessage() {
       .ShouldBe($"Info ({_testName}): {_testMsg}");
   }
 
+  [Fact]
+  public void FormatsStackTrace() {
+    var st = new FakeStackTrace("File.cs", "ClassName", "MethodName");
+    var formatter = new LogFormatter();
+    formatter.FormatMessage(_testName, st)
+      .ShouldBe($"Info ({_testName}): ClassName.MethodName in File.cs(1,2)");
+  }
+
+  [Fact]
+  public void FormatsStackTraceWithoutFile() {
+    var st = new FakeStackTrace(null, "ClassName", "MethodName");
+    var formatter = new LogFormatter();
+    formatter.FormatMessage(_testName, st)
+      .ShouldBe($"Info ({_testName}): ClassName.MethodName in **(1,2)");
+  }
+
+  [Fact]
+  public void FormatsStackTraceWithoutClass() {
+    var st = new FakeStackTrace("File.cs", null, "MethodName");
+    var formatter = new LogFormatter();
+    formatter.FormatMessage(_testName, st)
+      .ShouldBe($"Info ({_testName}): UnknownClass.MethodName in File.cs(1,2)");
+  }
+
+  [Fact]
+  public void FormatsStackTraceWithoutMethod() {
+    var st = new FakeStackTrace("File.cs", "ClassName", null);
+    var formatter = new LogFormatter();
+    // unknown method is also unknown class
+    formatter.FormatMessage(_testName, st)
+      .ShouldBe($"Info ({_testName}): UnknownClass.UnknownMethod in File.cs(1,2)");
+  }
+
   [Fact]
   public void FormatsWarning() {
     var formatter = new LogFormatter();