Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: recommend treating CS9057 as error #42

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

wlsnmrk
Copy link
Contributor

@wlsnmrk wlsnmrk commented Feb 21, 2025

Description

CS9057 is a compiler warning issued when a consuming project is using an earlier version of the .NET compiler than was used to compile the Introspection generator. Such a mismatch can have serious, hard-to-diagnose downstream consequences for users. (See chickensoft-games/Introspection#20 and chickensoft-games/GameDemo#104.) This change updates the documentation to recommend treating CS9057 as an error in consuming projects, to make those issues easier to diagnose and fix.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@wlsnmrk wlsnmrk force-pushed the doc/compiler-version-error branch from 65b1d97 to a8ce40a Compare February 21, 2025 16:37
CS9057 is a compiler warning issued when a consuming project is using
an earlier version of the .NET compiler than was used to compile the
Introspection generator. Such a mismatch can have serious,
hard-to-diagnose downstream consequences for users. This change
recommends treating CS9057 as an error in consuming projects, to make
those issues easier to diagnose and fix.
@wlsnmrk wlsnmrk force-pushed the doc/compiler-version-error branch from a8ce40a to 0d67312 Compare February 21, 2025 16:45
@wlsnmrk wlsnmrk requested a review from jolexxa February 21, 2025 16:52
@wlsnmrk wlsnmrk merged commit af77397 into chickensoft-games:main Feb 21, 2025
1 check passed
@wlsnmrk wlsnmrk deleted the doc/compiler-version-error branch February 21, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants