[Scala3] Rewrite svsim Verilator backend argument stringification #5042
+99
−117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src
?In Scala 3, stringification of C++ arguments in the svsim Verilator backend was leading to the arguments being wrapped in brackets instead of a space-joined string. This change updates the argument generation to stringify arguments individually before joining them, fixing the problem in Scala 3 testing
Type of Improvement
Desired Merge Strategy
Release Notes
Svsim Verilator Backend argument generation was refactored to work with Scala 3
Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
and clean up the commit message.Create a merge commit
.