Skip to content

refactor: use justfile as a command runner#255

Merged
chitralverma merged 4 commits intomainfrom
fix-build
Feb 17, 2026
Merged

refactor: use justfile as a command runner#255
chitralverma merged 4 commits intomainfrom
fix-build

Conversation

@chitralverma
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings February 17, 2026 08:55
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 17, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors the build system to use justfile as the primary command runner, moving native library build logic from bash scripts in justfile into sbt tasks. The refactoring aims to consolidate build logic and provide a cleaner interface through just commands.

Changes:

  • Moved native library generation logic from justfile bash script to sbt tasks in NativeBuildSettings.scala
  • Added utility functions in Utils.scala for process execution and logging
  • Created cleanHeaders command in ExtraCommands.scala
  • Simplified justfile recipes to delegate to sbt commands
  • Updated documentation (README.md, CONTRIBUTING.md) to reflect the new command patterns

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
project/Utils.scala Added executeProcess and getProcessLogger utility functions, plus nativeRoot taskKey definition
project/NativeBuildSettings.scala Moved native library build logic from justfile into generateNativeLibrary sbt task
project/GeneralSettings.scala Added settings sequence with nativeRoot configuration (unused)
project/ExtraCommands.scala Added cleanHeaders task to remove generated JNI headers
justfile Simplified recipes to delegate to sbt commands instead of containing bash logic
build.sbt Configured nativeRoot and applied ExtraCommands.commands
README.md Updated build commands to use just instead of direct sbt calls
CONTRIBUTING.md Updated development commands to use just instead of direct sbt calls

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

chitralverma and others added 2 commits February 17, 2026 14:39
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@chitralverma chitralverma merged commit fecb024 into main Feb 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants