Msys2 #891
Msys2 #891
Conversation
| Write-Host "Starting initialization via msys2_shell.cmd" | ||
| Start-Process "$install_dir\msys2_shell.cmd" -Wait -ArgumentList '-c', exit | ||
|
|
||
| if (!$pp.NoPath) { Install-ChocolateyPath $pp.InstallDir } |
There was a problem hiding this comment.
The path will need to be removed in an uninstall script.
|
|
||
| $pp = Get-PackageParameters | ||
| if (!$pp.InstallDir) { $pp.InstallDir = "{0}\{1}" -f (Get-ToolsLocation), $dir_name } | ||
| $install_dir = $pp.InstallDir |
There was a problem hiding this comment.
Since allowing custom installation directory, an uninstall script is needed to remove the path on uninstall.
There was a problem hiding this comment.
The original package was not removing the directory. I added a message as was there before as I also think its safer to not delete it. Perhaps there is no harm in removing it but its a minor issue anyway so I opted for the safe side.
|
Do we need to create a PR to remove from upstream repository? Or are we saying that this isn't needed since it isn't an automated repository i.e. AU/ketarin? |
|
I don't PR non automatic packages because there is no damage, links to package source on older versions work and maintenance is already a lot of work. |
|
Understood, just wanted to check. |
https://chocolatey.org/packages/msys2
Description
Embedded, made automatic package, and modernized. Documented relation with ruby installer.
How Has this Been Tested?
Locally
Types of changes
Checklist:
Original Location
/cc @userzimmermann @petemounce