Brings QSG into line with Environments Projects #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPRuskin
force-pushed
the
hardenNexusOperations
branch
2 times, most recently
from
61042cf to
636ebfd
Compare
|
Realised that I meant to mention that the build will be broken until we merge in the build changes, due to the security-first approach we take. If we're happy with the code changes here, I can add the build changes as a commit and the tests will call the right filenames. |
JPRuskin
force-pushed
the
hardenNexusOperations
branch
from
636ebfd to
b3115fc
Compare
JPRuskin
force-pushed
the
hardenNexusOperations
branch
from
b3115fc to
d41a37a
Compare
JPRuskin
force-pushed
the
hardenNexusOperations
branch
from
d41a37a to
d2992b1
Compare
JPRuskin
force-pushed
the
hardenNexusOperations
branch
from
d2992b1 to
0f17aef
Compare
Additionally, hardens some flakey Nexus operations to improve reliability.
Configuring the Nexus users and (optionally) SSL earlier in the Nexus script allows us to use the correct users and FQDNs immediately, and result in a more immediately available environment. Now that we are always doing these actions (e.g. securing the repositories), this should also reduce a lot of confusion with what the SSL script does.
Brings Jenkins configuration from the Set-SSL script to the Jenkins script, resulting in a correctly configured installation.
Customers are being confused by Set-SSL. This change removes remaining non-SSL-related operations from the script, which should allow it to be re-run if required (or accidentally) without issue.
This generator has no control over which characters are used and so was creating issues with our lazy replacements in the readme. This removes all uses of it in favour of the method used in New-ServicePassword, which is more controlled. Consequently, this commit also removes the New-CCMSalt function, which is now unused.
Previously, re-running could result in a user being in use and consequently not being dropped.
After discussion with Ryan, this results in a more obvious flow (and use) of script names. The quicklink and docs will need to be updated.
We should no longer tempt customer's fates by providing multiple things to enter into the terminal. Instead, we have a single thing to run, and we can drill in if we need to.
The installer should allow for testing beta packages where available, as long as we've specified the version. This should control that more precisely.
...by successfully removing it.
This updates Chocolatey dependencies within the repository to the latest available versions.
JPRuskin
force-pushed
the
hardenNexusOperations
branch
from
0f17aef to
9b2def1
Compare
I found this was missing when I trued up the docs PR.
JPRuskin
force-pushed
the
hardenNexusOperations
branch
from
6a292b3 to
df2af33
Compare
ryanrichter94
approved these changes
May 27, 2025
2 tasks
2 tasks
This was
linked to
issues
May 27, 2025
This was referenced May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Motivation and Context
This environment had several key differences to the other environments that could be brought into line, resulting in a more cohesive set of environments.
Testing
It's worth noting that this requires the latest NexuShell, chocolatey-licensed-jenkins-jobs, and chocolatey-licensed-jenkins-scripts packages available to succeed.
Operating Systems Testing
Change Types Made
Change Checklist
[ ] PowerShell code changes: PowerShell v3 compatibility checked?