Skip to content

Conversation

@ryanrichter94
Copy link
Member

@ryanrichter94 ryanrichter94 commented May 29, 2025

Description Of Changes

  • Create block for CCM Salt Generation
  • Ensures CCM Salt values are set in README.md file

Motivation and Context

Populate CCM salt value parameters in Register-C4bEndpoint.ps1

Testing

  1. Local QSG build on Server 2025

Operating Systems Testing

  • Server 2025 (local)
  • Server 2022 (automated tests)
  • Server 2019 (automated tests)

Change Types Made

  • [ ] Bug fix (non-breaking change).
  • [ ] Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • [ ] Documentation changes.
  • PowerShell code changes.

Change Checklist

  • [ ] Requires a change to the documentation.
  • [ ] Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • [ ] PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

Fixes #298

@ryanrichter94 ryanrichter94 force-pushed the QSG-298 branch 2 times, most recently from 1b3c4b9 to 5472a73 Compare May 29, 2025 17:22
@ryanrichter94 ryanrichter94 marked this pull request as ready for review May 29, 2025 17:22
Copy link
Contributor

@steviecoaster steviecoaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Barring testing, this looks good!

- Create block for CCM Salt Generation
- Ensures CCM Salt values are set to parameters in
  Register-C4bEndpoint.ps1
@steviecoaster steviecoaster merged commit 2506881 into main May 30, 2025
15 checks passed
@steviecoaster steviecoaster deleted the QSG-298 branch May 30, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CCM Salt Values Not Set Inside Register-C4bEndpoint Script

3 participants