Implementation #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisom79
reviewed
Sep 12, 2022
| Posicion pos = new Posicion(0, 0); | ||
| for(int i = 0; i < datos.length; i++){ | ||
| for(int j = 0; j < datos[i].length;j++){ | ||
| if(datos[i][j].equals(dato)){ |
Owner
There was a problem hiding this comment.
puedes tambien utilizar la creacion del objecto Posicion con new, esto solo te ahorra lineas codigo
chrisom79
reviewed
Sep 12, 2022
| int x = posicion.getX(); | ||
| int y = posicion.getY(); | ||
|
|
||
| return datos[x][y]; |
Owner
There was a problem hiding this comment.
puedes usar los getter dentro del array en lugar de asignacion de variables
chrisom79
reviewed
Sep 12, 2022
| public class UnidimensionalImpl implements Unidimensional { | ||
| @Override | ||
| public void ordenamiento(int[] arr) { | ||
| Arrays.sort(arr); |
Owner
There was a problem hiding this comment.
Buen uso de herramientas existentes
chrisom79
reviewed
Sep 12, 2022
| int[] arrcopy = new int[arr.length]; | ||
|
|
||
| int counter = 0; | ||
| for(int i = arr.length-1; i >= 0 ;i--){ |
Owner
There was a problem hiding this comment.
puedes volver a usar Arrays.sort() pero usando un comparator, que puedes pasar como parametro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.