Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove themes #250

Merged
merged 41 commits into from
Sep 20, 2024
Merged
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
3166a8c
refactor: extract logo to separate component
chrisvaillancourt Sep 10, 2024
3978c7e
refactor: move hover styles into relevant component
chrisvaillancourt Sep 10, 2024
51b2636
refactor: extract logo colors to css variables
chrisvaillancourt Sep 10, 2024
973b13b
build: update dependencies
chrisvaillancourt Sep 11, 2024
6c1ed29
fix: remove unnecessary pnpm version specifier
chrisvaillancourt Sep 12, 2024
98f47a2
feat: add heading attributes to props
chrisvaillancourt Sep 12, 2024
f7045ad
wip: header refactor
chrisvaillancourt Sep 12, 2024
a3a13f9
build: update dependencies
chrisvaillancourt Sep 12, 2024
eb9fffb
feat: simplify header layout
chrisvaillancourt Sep 12, 2024
70f1eb2
wip: css theme toggle
chrisvaillancourt Sep 13, 2024
b457a40
feat: update header grid
chrisvaillancourt Sep 13, 2024
3662c3f
chore: remove commented out class
chrisvaillancourt Sep 13, 2024
49fc16c
feat: reuse theme icons
chrisvaillancourt Sep 13, 2024
d81376d
feat: improve theme toggle tooltip
chrisvaillancourt Sep 13, 2024
56cd14c
chore: code formatting
chrisvaillancourt Sep 13, 2024
9cd4265
feat: use updated header
chrisvaillancourt Sep 13, 2024
3819f72
feat: add site icon to constants
chrisvaillancourt Sep 17, 2024
64c92aa
fix: remove unused data attribute
chrisvaillancourt Sep 17, 2024
182ac87
feat: emit theme change event
chrisvaillancourt Sep 18, 2024
9800dc8
build: update dependencies
chrisvaillancourt Sep 18, 2024
72f3d0a
fix: inline js to prevent theme icon from switching after load
chrisvaillancourt Sep 18, 2024
7eed581
chore: remove unused import
chrisvaillancourt Sep 18, 2024
f870462
fix: remove unused class
chrisvaillancourt Sep 18, 2024
8ded16d
docs: add info on why we need to inline script
chrisvaillancourt Sep 18, 2024
d500c03
chore: remove old theme toggle
chrisvaillancourt Sep 18, 2024
4ab8e97
refactor: rename theme toggle
chrisvaillancourt Sep 18, 2024
83f7c29
feat: remove theme toggle
chrisvaillancourt Sep 18, 2024
12cc491
feat: simplify header layout
chrisvaillancourt Sep 18, 2024
098ef4c
feat: pass logo and nav links as props
chrisvaillancourt Sep 18, 2024
2652ad4
refactor: pass logo, links, and title as props and slot
chrisvaillancourt Sep 18, 2024
6dfdbb9
feat: check if links exists and has items
chrisvaillancourt Sep 18, 2024
b257742
refactor: extract links type to shared type
chrisvaillancourt Sep 18, 2024
793fb11
feat: make footer links an unordered list
chrisvaillancourt Sep 19, 2024
4c334b4
build: update dependencies
chrisvaillancourt Sep 19, 2024
fe055ba
feat: add json parse util
chrisvaillancourt Sep 19, 2024
cf0df83
feat: force dark mode
chrisvaillancourt Sep 19, 2024
eddf42a
feat: remove light theme from site config
chrisvaillancourt Sep 20, 2024
02a9731
chore: remove unused logo
chrisvaillancourt Sep 20, 2024
0682f7b
refactor: remove json util
chrisvaillancourt Sep 20, 2024
bc74556
build: only specify major and minor version of git
chrisvaillancourt Sep 20, 2024
8263d72
test: remove unnecessary tests
chrisvaillancourt Sep 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: make footer links an unordered list
chrisvaillancourt committed Sep 19, 2024
commit 793fb1111be99a36aba93b2883f1421a56802f31
25 changes: 13 additions & 12 deletions src/components/Footer.astro
Original file line number Diff line number Diff line change
@@ -26,18 +26,19 @@ const year = new Date().getFullYear();
</div>
{
links?.length > 0 && (
<nav
aria-label="More on this site"
class="flex gap-x-2 sm:gap-x-0 sm:divide-x sm:divide-gray-500"
>
{links.map((link) => (
<Link
href={link.path}
class="sm:hover:text-textColor px-4 py-2 sm:px-2 sm:py-0 sm:hover:underline"
>
{link.title}
</Link>
))}
<nav aria-label="More on this site">
<ul class="flex gap-x-2 sm:gap-x-0 sm:divide-x sm:divide-gray-500">
{links.map((link) => (
<li>
<Link
href={link.path}
class="sm:hover:text-textColor px-4 py-2 sm:px-2 sm:py-0 sm:hover:underline"
>
{link.title}
</Link>
</li>
))}
</ul>
</nav>
)
}