[ENH]: add_task/remove_task API for tasks framework

[tanujnay112]

Description of changes

Summarize the changes made by this PR.

• Improvements & Bug fixes
  • ...
• New functionality
  • ...

Test plan

How are these changes tested?

• Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Migration plan

Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?

Observability plan

What is the plan to instrument and monitor this change?

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the _docs section?_

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[tanujnay112]

• [ENH]: add_task/remove_task API for tasks framework #5545 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[tanujnay112]

3 Jobs Failed:

PR checks / all-required-pr-checks-passed failed on "Decide whether the needed jobs succeeded or failed"

[...]
}
EOM
)"
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  GITHUB_REPO_NAME: chroma-core/chroma
  PYTHONPATH: /home/runner/_work/_actions/re-actors/alls-green/release/v1/src
# ❌ Some of the required to succeed jobs failed 😢😢😢

📝 Job statuses:
📝 python-tests → ✓ success [required to succeed or be skipped]
📝 python-vulnerability-scan → ✓ success [required to succeed or be skipped]
📝 javascript-client-tests → ✓ success [required to succeed or be skipped]
📝 rust-tests → ✓ success [required to succeed or be skipped]
📝 go-tests → ❌ failure [required to succeed or be skipped]
📝 lint → ❌ failure [required to succeed]
📝 check-helm-version-bump → ⬜ skipped [required to succeed or be skipped]
📝 delete-helm-comment → ✓ success [required to succeed or be skipped]
Error: Process completed with exit code 1.

PR checks / Go tests / cluster-test failed on "Run bin/cluster-test.sh bash -c 'cd go && make test'"

[...]
Error: pkg/sysdb/coordinator/table_catalog_test.go:557:41: cannot use mockMetaDomain (variable of type *mocks.IMetaDomain) as dbmodel.IMetaDomain value in argument to NewTableCatalog: *mocks.IMetaDomain does not implement dbmodel.IMetaDomain (missing method TaskDb)
Error: pkg/sysdb/coordinator/table_catalog_test.go:747:41: cannot use mockMetaDomain (variable of type *mocks.IMetaDomain) as dbmodel.IMetaDomain value in argument to NewTableCatalog: *mocks.IMetaDomain does not implement dbmodel.IMetaDomain (missing method TaskDb)
Error: pkg/sysdb/coordinator/table_catalog_test.go:839:41: cannot use mockMetaDomain (variable of type *mocks.IMetaDomain) as dbmodel.IMetaDomain value in argument to NewTableCatalog: *mocks.IMetaDomain does not implement dbmodel.IMetaDomain (missing method TaskDb)
Error: pkg/sysdb/coordinator/table_catalog_test.go:839:41: too many errors
FAIL	github.com/chroma-core/chroma/go/pkg/sysdb/coordinator [build failed]
	github.com/chroma-core/chroma/go/pkg/sysdb/coordinator/model		coverage: 0.0% of statements
ok  	github.com/chroma-core/chroma/go/pkg/sysdb/grpc	7.789s	coverage: 38.6% of statements
ok  	github.com/chroma-core/chroma/go/pkg/sysdb/metastore/db/dao	7.130s	coverage: 49.6% of statements
	github.com/chroma-core/chroma/go/pkg/sysdb/metastore/db/dao/daotest		coverage: 0.0% of statements
	github.com/chroma-core/chroma/go/pkg/sysdb/metastore/db/dbcore		coverage: 0.0% of statements
	github.com/chroma-core/chroma/go/pkg/sysdb/metastore/db/dbmodel		coverage: 0.0% of statements
	github.com/chroma-core/chroma/go/pkg/sysdb/metastore/db/dbmodel/mocks		coverage: 0.0% of statements
	github.com/chroma-core/chroma/go/pkg/sysdb/metastore/s3		coverage: 0.0% of statements
	github.com/chroma-core/chroma/go/pkg/types		coverage: 0.0% of statements
ok  	github.com/chroma-core/chroma/go/pkg/utils	(cached)	coverage: 31.2% of statements
	github.com/chroma-core/chroma/go/shared/libs		coverage: 0.0% of statements
	github.com/chroma-core/chroma/go/shared/otel		coverage: 0.0% of statements
FAIL
make: *** [Makefile:34: test] Error 1
Error: Process completed with exit code 2.

PR checks / Lint failed on "Cargo fmt check"

[...]
  PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.11.13/x64/lib/pkgconfig
  Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.13/x64
  Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.13/x64
  Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.13/x64
  LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.11.13/x64/lib:/opt/hostedtoolcache/Python/3.9.23/x64/lib
  CACHE_ON_FAILURE: false
  CARGO_INCREMENTAL: 0
Diff in /home/runner/_work/chroma/chroma/rust/types/src/lib.rs:17:
 mod signed_rbm;
 mod spann_configuration;
 mod spann_posting_list;
-mod task;
 #[cfg(feature = "testing")]
 pub mod strategies;
+mod task;
 mod tenant;
 mod validators;
 mod where_parsing;
Error: Process completed with exit code 1.

---

Summary: 1 successful workflow, 1 failed workflow

• ✅ Check PR Title (1 job succeeded)
• ❌ PR checks (51 jobs succeeded, 3 jobs failed)

Last updated: 2025-10-02 07:43:01 UTC