- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.9k
[ENH]: Added ability to use a diffferent API endpoint for OpenAI Embedding Function #5646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added ability to change API's Base URL in OpenAI Embedding Function.
Added documentation for apiBase parameter to OpenAI Embedding Function docs
| Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
 System Compatibility
 Quality
 | 
| Add Custom API Endpoint Support for OpenAI Embedding Function in TypeScript This PR introduces the ability to specify a custom API base URL ( Key Changes• Added  Affected Areas•  This summary was automatically generated by @propel-code-bot | 
| @kylediaz Please review the PR, thanks! | 
Addressed the issue where undefined paramater could be mishandled by OpenAI SDK
Added apiBase to OpenAIConfig so it can properly be used/saved
Changed if statement to follow Typescript conventions Changed variable name from a reserved name to avoid runtime issues
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustMigration plan
Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?
No need. This change is backwards compatible.
Observability plan
What is the plan to instrument and monitor this change?
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?
Documentation has been updated to reflect the changes.