-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[ENH]: add create_collection() to Rust client #5655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH]: add create_collection() to Rust client #5655
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
if let Some(response) = maybe_response { | ||
let json = response.json::<serde_json::Value>().await?; | ||
|
||
if tracing::enabled!(tracing::Level::TRACE) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now logs response JSON on failed requests
will add a custom error type for when we receive parsable JSON errors in a follow up PR
Add This PR implements two new methods, Key Changes• Added Affected Areas• This summary was automatically generated by @propel-code-bot |
7a43dc3
to
703a271
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
703a271
to
0e9ef4c
Compare
Merge activity
|
Description of changes
Adds
create_collection()
andget_or_create_collection()
to the Rust client, also wires uplist_collections()
.Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustMigration plan
Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?
Observability plan
What is the plan to instrument and monitor this change?
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?