Skip to content

Add Row and Col components #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wagnermoschini
Copy link

this PR is inspired on @chromakode feedback on pr #21

//example of proposal
<Row>
  <Col>{...}</Col>
  <Col>{...}</Col>
</Row>

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@de060c8).


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de060c8...2cc06db. Read the comment docs.

@singingwolfboy
Copy link

@chromakode Any feedback on this? This pull request has been open for several months, and it looks really handy. Is it ready to be merged into master and released? If not, is there anything I can do to help make it ready?

@robinknox
Copy link

Likewise, I'd really like to see this functionality added since I need multi-column support for my emails.

@chromaci
Copy link

chromaci commented Nov 4, 2017 via email

@searls
Copy link

searls commented Jan 10, 2018

+1 to taking a look at merging this. I think I'm going to probably work off a fork to get these two components since it seems necessary to do a 2-column layout

@searls searls mentioned this pull request Jan 11, 2018
2 tasks
@giulioambrogi
Copy link

Any update on this?

@kopax
Copy link

kopax commented Oct 10, 2018

Hi, any update on this? @chromaci vacation still?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants