Fix #75: Implement web app installing#105
Fix #75: Implement web app installing#105FluorescentHallucinogen wants to merge 1 commit intochromium:masterfrom
Conversation
engedy
left a comment
engedy
left a comment
There was a problem hiding this comment.
Looks good to me % a question and one request below.
There was a problem hiding this comment.
Is this just the scaled up version of https://github.com/chromium/permission.site/blob/master/app-icon.png?
| "purpose": "maskable" | ||
| } | ||
| ], | ||
| "screenshots": [ |
There was a problem hiding this comment.
Could you please move the screenshots into their own folder to avoid having too many files in the root directory?
lgarron
left a comment
lgarron
left a comment
There was a problem hiding this comment.
Some thoughts:
I think using a larger app icon is good. I think keeping the main resolution at app-icon.png would be nice for continuity, but file names based on sizes are okay. (As @engedy points out, though, it would be good to place them in an img folder.)
The large icons in this PR don't match the existing icon, though. Here are 2880w, 512w, 192w, and SVG versions of the original icon:
I love the idea of showing resolutions in the screenshots, but I would propose using a more neutral font matching the rest of the website, and ideally incorporating the app icon in addition the the resolution text.
| <td>Async Clipboard</td> | ||
| <td> | ||
| These buttons test the new <a href="https://w3c.github.io/clipboard-apis/">Async Clipboard API</a>. | ||
| These buttons test the new <a href="https://w3c.github.io/clipboard-apis/" target="_blank">Async Clipboard API</a>. |
There was a problem hiding this comment.
This change is not related to the rest of the PR. I'd suggest making a separate PR for this.
| { | ||
| "name": "permission.site", | ||
| "short_name": "permission.site", | ||
| "description": "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.", |
There was a problem hiding this comment.
I think this should be a real description. I think the GitHub project description would be good:
A site to test the interaction of web APIs and browser permissions.
| "name": "permission.site", | ||
| "short_name": "permission.site", | ||
| "description": "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.", | ||
| "start_url": "./?utm_source=web_app_manifest", |
There was a problem hiding this comment.
Any reason we need to use URLs with web tracking parameters?
| "start_url": "./?utm_source=web_app_manifest", | |
| "start_url": "./", |
(If there is a good reason, that should probably be documented.)
| <title>permission.site</title> | ||
| <link rel="shortcut icon" href="favicon.ico"> | ||
| <link rel="apple-touch-icon" href="app-icon.png"/> | ||
| <link rel="shortcut icon" href="icon-512x512.png"> |
There was a problem hiding this comment.
Why replace favicon.ico? The existing favicon is sized specifically arranged for low resolution.
| <title>permission.site (one-time)</title> | ||
| <link rel="shortcut icon" href="favicon.ico" /> | ||
| <link rel="apple-touch-icon" href="app-icon.png" /> | ||
| <link rel="shortcut icon" href="icon-512x512.png"> |
There was a problem hiding this comment.
Same as the main page shortcut icon.
| <title>permission.site</title> | ||
| <link rel="shortcut icon" href="favicon.ico" /> | ||
| <link rel="apple-touch-icon" href="app-icon.png" /> | ||
| <link rel="shortcut icon" href="icon-512x512.png"> |
There was a problem hiding this comment.
Also same as the main page shortcut icon.
|
@FluorescentHallucinogen: Do you plan to revisit this? |
Okay, I’ll address all the comments in the near future. By the way, the Web Install API has appeared in the meantime. I could add it as well. |
3 participants
No description provided.