Fetch entities #7
Conversation
quorth0n
requested review from
MiklerGM,
Padavan,
amaury1093,
ataalik and
v1kun
| "wikidata_id": int(entity["entity"]["value"].split("Q", 1)[1]), | ||
| "color": "#fff", # TODO: change | ||
| "admin_level": 1, | ||
| "predecessors": [] # entity["predecessors"]["value"] |
There was a problem hiding this comment.
FKEYs are enforced on a db level to maintain integrity, should we change this to be able to store predecessor relationships to entities not in our db?
There was a problem hiding this comment.
afaik predecessor field was disabled for mvp and primary key has been changed to id
It's better to keep this field as FKEY in the future.
| for entity in ENTITIES["results"]["bindings"]: | ||
| data = { | ||
| "wikidata_id": int(entity["entity"]["value"].split("Q", 1)[1]), | ||
| "color": "#fff", # TODO: change |
There was a problem hiding this comment.
Are "wish" colors to be assigned manually?
There was a problem hiding this comment.
Right now it's an int field in database.
| for entity in ENTITIES["results"]["bindings"]: | ||
| data = { | ||
| "wikidata_id": int(entity["entity"]["value"].split("Q", 1)[1]), | ||
| "color": "#fff", # TODO: change |
There was a problem hiding this comment.
Right now it's an int field in database.
| "wikidata_id": int(entity["entity"]["value"].split("Q", 1)[1]), | ||
| "color": "#fff", # TODO: change | ||
| "admin_level": 1, | ||
| "predecessors": [] # entity["predecessors"]["value"] |
There was a problem hiding this comment.
afaik predecessor field was disabled for mvp and primary key has been changed to id
It's better to keep this field as FKEY in the future.
Blocked by #1