add CommandInjection.java #128
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| public class CommandInjection { | ||
| public static Process runCmd(HttpServletRequest request) throws IOException { | ||
| String filename = request.getParameter("filename"); | ||
| ProcessBuilder builder = new ProcessBuilder("cat", filename); |
There was a problem hiding this comment.
Auto-generated PR comment (Coverity)
Coverity Issue - OS Command Injection
High CWE-78
Calling "ProcessBuilder". Passing the tainted value "{"cat", filename}" to the process-invoking API may allow an attacker to modify the intention of the command.
A user can change the intent of an operating system command. This change may result in the disclosure, destruction, or modification of sensitive data or operating system resources.
How to fix
Ensure the tainted data cannot modify the intent of the OS command. If possible, use a safer library or API call instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.