Skip to content

add cmd-injection.js #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chuckaude wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add cmd-injection.js #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions lib/cmd-injection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// https://documentation.blackduck.com/bundle/coverity-docs/page/checker-ref/checkers/NO/os_cmd_injection.html

const express = require("express");
const app = express();
Copy link

@github-actions github-actions bot May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated PR Comment From coverity

Coverity Issue - Sending X-Powered-By header

Low CWE-201
HTTP responses contain an X-Powered-By header that reveals information about the server which helps attackers exploit known vulnerabilities or craft more targeted exploits.

How to fix

Use app.disable('x-powered-by') to disable the X-Powered-By header. If you're using an older version of Express that does not support this setting and you can't upgrade, create a middleware to call res.removeHeader("x-powered-by") where res is the response object.


app.get("/run", function run(req, res, next) { // OS_CMD_INJECTION defect
require("child_process").exec(req.query.cmd);
Copy link

@github-actions github-actions bot May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated PR Comment From coverity

Coverity Issue - OS Command Injection

High CWE-78
Calling "require("child_process").exec" with the tainted value in "req.query.cmd". This passes the tainted value to the process-invoking API and may thus allow an attacker to modify the intention of the command.

A user can change the intent of an operating system command. This change may result in the disclosure, destruction, or modification of sensitive data or operating system resources.

How to fix

Ensure the tainted data cannot modify the intent of the OS command. Sanitize the data before using inside a sensitive function call. If possible, use a safer library or API call instead.

res.send("Done");
});
app.listen(1337, function() {
console.log("Express listening...");
});