Skip linters early if affected package is not imported #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip the ioreadall, slowg and timeafter linters early if the respective packages they check for (i.e. io, slog/log, golang.org/x/exp/slog and time) is not imported by the package that is currently analyzed. This should reduce linter run time a bit on packages that don't import any of the checked packages. Signed-off-by: Tobias Klauser <[email protected]>
tklauser
force-pushed
the
pr/tklauser/skip-unaffected-imports
branch
from
6318c5a to
9a4c98d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip the ioreadall, slowg and timeafter linters early if the respective packages they check for (i.e. io, slog/log, golang.org/x/exp/slog and time) is not imported by the package that is currently analyzed. This should reduce linter run time a bit on packages that don't import any of the checked packages.