update docker-related scripts to get them working and other minor miscellaneous fixes #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated github workflow actions' versions - standardized in scripting and documentation calls to pip (from "pip" to "python3 -m pip") - updated copyright year to 2024 - update base Docker image from Ubuntu kinetic to jammy - added "EXPOSE 5000" directive to Dockerfile for web UI server (although did not test the web UI server through docker) - removed deprecated misc/scan script (which is no longer maintained and will be removed) from local.zeek - updated navv-docker.sh command to run `generate` as default command - although the documentation specified --output-dir and --zeek-logs would default to the current directory, this was not being done; added default=os.getcwd() to @click.option for those two parameters - handled case in pushd context manager where new_dir was being passed in as None, causing an exception Signed-off-by: Seth Grover <[email protected]>
Signed-off-by: Seth Grover <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to get Dockerized version working correctly and other miscellany
generateas default command@Dbones202 I've only tested the CLI
generatecommand from within the docker container and via thenavv-docker.shscript, and did not test/run/mess with anything to do with the web UI. While I don't think any of my changes should have any effect on the UI command, you might want to double-check that.