-
Notifications
You must be signed in to change notification settings - Fork 29
Update LIFL Documentation #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Added documentation for running LIFL on an external drive
This PR fixes issue #613 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akwaed Thank you for your interest and contribution. One comment was left. Can you please address it?
|
||
logger.debug("channel leave completed gracefully") | ||
|
||
# def leave(self, channel) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please remove these commented lines?
@ShixiongQi For your attention. |
I will take a look |
Description
This PR is to update the LIFL's documentation, including how to setup the environment and deps. This PR also includes several minor fixes on dependency issue caused by pip update and also documentation on how to run the
coord_hier_syncfl_mnist
example.Also added doc on how to install dependencies on a /mnt/ drive
Note that by not including a description, you are asking reviewers to do extra work to understand the context of this
change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.
Type of Change
Checklist