Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server/gamestate): vehicles natives #3071

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(server/gamestate): vehicles natives #3071

wants to merge 1 commit into from
+100 −3

Conversation

spacevx
Copy link
Contributor

@spacevx spacevx commented Jan 15, 2025 •
edited
Loading

Goal of this PR

  • Added IS_VEHICLE_IN_AIR
  • Added IS_VEHICLE_DROWNING
  • Added GET_PED_DEATH_STATE to check if a player is alive, dying or dead.

How is this PR achieving the goal

By exposing fields in datanodes that were already read, (i couldn't find doc about DeathState_Max tho)

This PR applies to the following area(s)

Server, Natives

Successfully tested on

Game builds: 3095, 3258

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Jan 15, 2025
@spacevx
feat(server/gamestate): vehicles natives
b171ffa 
* Added IS_VEHICLE_IN_AIR
* Added IS_VEHICLE_DROWNING
* Added GET_DEATH_STATE to check if a player is alive, dying or dead.
@github-actions github-actions bot added invalid Requires changes before it's considered valid and can be (re)triaged and removed triage Needs a preliminary assessment to determine the urgency and required action labels Jan 15, 2025
@Heisenberg691
Copy link

DeathState_Max acts as a boundary marker. It defines the range of valid eDeathState values.
And why do we need IS_VEHICLE_IN_AIR when there is IS_ENTITY_IN_AIR?

@spacevx
Copy link
Contributor Author

spacevx commented Jan 16, 2025

DeathState_Max acts as a boundary marker. It defines the range of valid eDeathState values. And why do we need IS_VEHICLE_IN_AIR when there is IS_ENTITY_IN_AIR?

Good to know thanks, and IS_ENTITY_IN_AIR is client side, a server side native is still better.

@AvarianKnight
Copy link
Contributor

IS_ENTITY_IN_AIR

They're saying to reuse the name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
invalid Requires changes before it's considered valid and can be (re)triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spacevx @Heisenberg691 @AvarianKnight