fix(ego-browser): recover help() from live helpers when docs are empty - #289
Open
chenjiangjiang85-jpg wants to merge 1 commit into
Open
Conversation
citrolabs#84/citrolabs#85 embed helper docs at build time, but ego lite 0.4.6.14 still ships an empty catalog so help('click') returns Unknown helper. Fall back to the live function signature when the embedded map is empty or missing a helper, and keep Unknown helper only for names that are not present at all. Closes citrolabs#287
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
help()still returnsUnknown helperfor every helper on the shipped ego lite 0.4.6.14 app. Recover a usable signature from the live helper function when the embedded docs catalog is empty or missing that name.Related issue
Closes #287
Related: #84, #85, #273
Changes
help()has no names and the embedded catalog is empty, list live helpers from the current helper context.help(name)misses an embedded doc, recover the signature from the live function instead of immediately returningUnknown helper.Unknown helperonly for names that are not present as live functions.Verification
Local 0.4.6.14 app still reproduces the empty catalog:
This PR does not patch the closed-source app binary. It makes the next runtime ship degrade to live signatures instead of an empty catalog.
Impact
help()remains the same public function. Agents that currently get an empty string /Unknown helperwill get recovered signatures when the helper exists. True unknown names are unchanged.Checklist
devfor normal changes; onlydevmay targetmain).feat,fix,docs,chore,ci, orrefactor).