Use has_privs_of_role instead of is_member_of_role in UserHasPermissionToViewStatsOf() #7923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onToViewStatsOf As of postgres/postgres@6198420, the usage of is_member_of_role is replaced by has_privs_of_role for pg_stat_activity, pg_stat_statements and many others.
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7923 +/- ##
==========================================
+ Coverage 89.32% 89.38% +0.06%
==========================================
Files 283 283
Lines 60522 60522
Branches 7544 7544
==========================================
+ Hits 54060 54099 +39
+ Misses 4284 4247 -37
+ Partials 2178 2176 -2 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of postgres/postgres@6198420, the usage of is_member_of_role is replaced by has_privs_of_role for pg_stat_activity, pg_stat_statements and many others.
TODO: Need to better understand the implications of this change and need to add a few tests.
DESCRIPTION: PR description that will go into the change log, up to 78 characters