Repository navigation
Conversation
3DBAG publishes what its own reconstruction pipeline measured for every building. Those figures are an independent toolchain's answer for the very geometry it shipped, and until now only two of them were used. Adds volume at LoD1.2 and LoD1.3, surface area against the five b3_opp_* attributes summed, ST_3DZMin against b3_h_maaiveld, the LoD1.2 extrusion height against b3_h_dak_70p, and val3dity's error list against ST_3DValidationReport. The area identity is the one that matters most: every LoD2.2 face carries exactly one semantic role, so the five published areas sum to the whole boundary, and ST_3DSurfaceArea had no oracle at all on real geometry -- SFCGAL rejects eight of the nine fixture solids for non-planarity. cityjson_3dbag_attributes.test runs the comparisons offline over the frozen nine-building slice, at the tolerances that slice actually meets; cityjson_delft_remote.test runs them at tile scale, where a tile contains reconstructions that are simply broken and the thresholds have to be fractions. Numeric pins in both files are now formatted and compared as text: sqllogic compares numeric results with a 1 % relative tolerance (ApproxEqual in duckdb/src/common/types.cpp), so the existing ROUND(volume, 1) = 19.5 pin would have passed at 19.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.