This repository has been archived by the owner on Sep 25, 2024. It is now read-only.
Added Maestro support #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed. Did you run tests locally? |
|
Sorry, I was in a bit of a rush. Just fixed the issue and ran the tests. I haven't added any explicit tests for Maestro. |
|
This needs tests in order to be considered. |
|
Maestro cards also require a start date for the card. I'll take a look more at adding this, plus tests in the next few days. |
|
I don't want to start adding custom attributes like start date, especially for something described as a "dying format." |
|
Start date is a common field in the UK. E.g. my Visa Debit and Mastercard has a start date. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.