Skip to content

Turn Help action into Bindings #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pihart wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Turn Help action into Bindings #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5584319
Action.Help is now Action.Bindings
pihart Jun 3, 2021
818101c
New Bindings action should have keyboard icon
pihart Jun 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Icon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const Icon: Record<Action, JSX.Element> & Record<string, JSX.Element> = {

duplicate: fasIcon("clone"),

help: fasIcon("question"),
help: fasIcon("keyboard"),
fullScreen: fasIcon("expand"),
enterFullScreen: fasIcon("expand"),
exitFullScreen: fasIcon("compress"),
Expand Down
2 changes: 1 addition & 1 deletion src/components/Stylebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const Stylebar = (props: {
const otherActions = [
Action.Copy,
Action.Paste,
Action.Help,
Action.Bindings,
!isFullscreen ? Action.EnterFullScreen : Action.ExitFullScreen,
];

Expand Down
2 changes: 1 addition & 1 deletion src/lib/action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export enum Action {
HalfFilled = "halfFilled",
Filled = "filled",

Help = "help",
Bindings = "help",
ResetStyles = "resetStyles",
FullScreen = "fullScreen",
EnterFullScreen = "enterFullScreen",
Expand Down
18 changes: 9 additions & 9 deletions src/lib/keyboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ export const defaultKeys: KeyMap = {
"ctrl + x": Action.Cut,
"ctrl + c": Action.Copy,

"1": Action.Help,
"0": Action.Help,
"/": Action.Help,
"shift + /": Action.Help,
"1": Action.Bindings,
"0": Action.Bindings,
"/": Action.Bindings,
"shift + /": Action.Bindings,
};

export default class KeyboardHandler {
Expand Down Expand Up @@ -75,12 +75,12 @@ export default class KeyboardHandler {

// for backwards compatibility, ensure help is bound
if (
Object.values(this.keyMap).every((action) => action !== Action.Help)
Object.values(this.keyMap).every((action) => action !== Action.Bindings)
) {
this.bind("0", Action.Help);
this.bind("1", Action.Help);
this.bind("/", Action.Help);
this.bind("shift + /", Action.Help);
this.bind("0", Action.Bindings);
this.bind("1", Action.Bindings);
this.bind("/", Action.Bindings);
this.bind("shift + /", Action.Bindings);
}
}
}
Expand Down