Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: java.util.NoSuchElementException: head of empty list #140

Merged
merged 1 commit into from
Jan 6, 2025
Merged

fix: java.util.NoSuchElementException: head of empty list #140

merged 1 commit into from
Jan 6, 2025

Conversation

nightscape
Copy link
Contributor

No description provided.

@nightscape nightscape marked this pull request as ready for review January 4, 2025 10:05
@nightscape
Copy link
Contributor Author

I've tried this on a Mill-based project of mine and it seems to work. I'm just having some issues with the Sonatype Credentials, but I think that has nothing to do with mill-ci-release. @ckipp01 @carlosedp shall we give this PR a try, and if it doesn't work, use #137 (which adds a bit more code duplication, but is tested to work)?

@carlosedp
Copy link
Contributor

Just confirmed this PR works on projects using mill 0.11.12 and 0.12.5.
Better than my PR #137 which has more code duplication.

@carlosedp carlosedp mentioned this pull request Jan 6, 2025
Closed
ckipp01
ckipp01 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Owner

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ckipp01 ckipp01 merged commit 4a2107c into ckipp01:main Jan 6, 2025
2 checks passed
@carlosedp
Copy link
Contributor

Thanks @ckipp01 and @nightscape ... I think it might need a bump in it's own publishing version since it's failing.

@carlosedp carlosedp mentioned this pull request Jan 6, 2025
Closed
@nightscape nightscape deleted the fix-discovery branch January 7, 2025 08:14
@ckipp01
Copy link
Owner

ckipp01 commented Jan 7, 2025

ugh, now we are getting a different error... https://github.com/ckipp01/mill-ci-release/actions/runs/12659334624/job/35278228882

@carlosedp
Copy link
Contributor

Oh, I've seen it before but never understood what was causing it since the traceback is not clear...

@carlosedp
Copy link
Contributor

See the first report at #134 (comment)

@nightscape
Copy link
Contributor Author

See #143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckipp01 ckipp01 ckipp01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nightscape @carlosedp @ckipp01