Skip to content

Conversation

CatarinaSilva
Copy link

  • The older expression (before May) was comparing probabilities with logarithms, and although this was fixed with the previous commit the expression should be a sum and not a multiplication, to keep the same meaning.
  • Also, multiplying the beam threshold with the log(10) factor turns the parameter more intuitive
  • The default threshold also makes more sense with this expression

@tomaspinho
Copy link

@redpony comments on this are deeply appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants