Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
fd68459
useAsModal: delete --unused
clairep94 Aug 25, 2025
554a2f0
RootPage: update to tsx --no-verify
clairep94 Aug 25, 2025
3120c79
RootPage: add interface and update to named export
clairep94 Aug 25, 2025
06ca7b2
PreviewNav: update to tsx --no-verify
clairep94 Aug 25, 2025
2e23c92
PreviewNav: add test, add interface and update to named export. Add d…
clairep94 Aug 25, 2025
d07b296
Dropdown --> DropdownWrapper: update to tsx and move folders --no-verify
clairep94 Aug 25, 2025
9e95601
DropdownMenu: move DropdownWrapper directly into DropdownMenu as Styl…
clairep94 Aug 25, 2025
f050cfc
DropdownWrapper: Delete file, only styled dropdown wrapper is used in…
clairep94 Aug 25, 2025
fc85d29
MenuItem: migrate to tsx --no-verify
clairep94 Aug 25, 2025
1b6ad1f
MenuItem: add interface, update to named export
clairep94 Aug 25, 2025
01cb10e
ButtonOrLink: add basic html element attributes as optional props
clairep94 Aug 25, 2025
c6221b5
DropdownMenu: update to tsx --no-verify
clairep94 Aug 25, 2025
9a4cea5
DropdownMenu: add interface, update to named export. no-verify due to…
clairep94 Aug 25, 2025
ffa2801
TableDropdown: migrate to tsx --no-verify
clairep94 Aug 25, 2025
5242b85
TableDropdown: add interface and update to named export
clairep94 Aug 25, 2025
a3fe730
MenuBar/contexts: update to tsx no-verify
clairep94 Aug 25, 2025
e2aca23
contexts: add types
clairep94 Aug 25, 2025
47a85d5
Menubar/MenubarItem: migrate to tsx no-verify
clairep94 Aug 25, 2025
12bf9a6
MenubarItem: add interface, update to default export, add minimal typ…
clairep94 Aug 25, 2025
dffd07b
Menubar: migrate to tsx no verify
clairep94 Aug 26, 2025
fd42fa4
Menubar: add interface and update to named export, wip no-verify
clairep94 Aug 28, 2025
96b0a39
merge with develop and update to /common pr
clairep94 Aug 28, 2025
51b69d9
MenuBar: fix ts errors from keydownHandler and useModalClose
clairep94 Aug 28, 2025
936238c
MenuBar: test update to tsx
clairep94 Aug 28, 2025
9b1e574
MenubarSubmenu: update to tsx, no-verify
clairep94 Aug 28, 2025
50c2821
MenubarSubmenu: wip - update context related type errors, and update …
clairep94 Sep 1, 2025
11fcf49
WIP fix type errors on MenubarSubmenu --no-verify
clairep94 Sep 1, 2025
de2f404
wip -- abandon --no-verify
clairep94 Sep 1, 2025
1d35452
Merge branch 'develop' into pr05/migrate_client_components_rebuild
clairep94 Sep 1, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Stay in touch with Processing Foundation across other platforms:
- [Instagram](https://www.instagram.com/p5xjs)
- [Youtube](https://www.youtube.com/@ProcessingFoundation)
- [X](https://x.com/p5xjs)
- Discord (invitation link coming soon!)
- [Discord](https://discord.com/invite/esmGA6H6wm)
- [Forum](https://discourse.processing.org)


Expand Down
2 changes: 1 addition & 1 deletion client/common/ButtonOrLink.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Link } from 'react-router-dom';
/**
* Accepts all the props of an HTML <a> or <button> tag.
*/
export interface ButtonOrLinkProps {
export interface ButtonOrLinkProps extends React.HTMLAttributes<HTMLElement> {
/**
* Can be internal or external ('http'- or 'https'-).
*/
Expand Down
4 changes: 2 additions & 2 deletions client/common/useKeyDownHandlers.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { mapKeys } from 'lodash';
import { useCallback, useEffect, useRef } from 'react';
import React, { useCallback, useEffect, useRef } from 'react';
import { isMac } from '../utils/device';

/** Function to call upon keydown */
export type KeydownHandler = (e: KeyboardEvent) => void;
export type KeydownHandler = (e: KeyboardEvent | React.KeyboardEvent) => void;
/** An object mapping from keys like 'ctrl-s' or 'ctrl-shift-1' to handlers. */
export type KeydownHandlerMap = Record<string, KeydownHandler>;

Expand Down
8 changes: 4 additions & 4 deletions client/common/useModalClose.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ import { useKeyDownHandlers } from './useKeyDownHandlers';
* @param passedRef - Optional ref to the modal element. If not provided, one is created internally.
* @returns A ref to be attached to the modal DOM element
*/
export function useModalClose(
export function useModalClose<T extends HTMLElement = HTMLElement>(
onClose: () => void,
passedRef?: MutableRefObject<HTMLElement | null>
): MutableRefObject<HTMLElement | null> {
const createdRef = useRef<HTMLElement | null>(null);
passedRef?: MutableRefObject<T | null>
): MutableRefObject<T | null> {
const createdRef = useRef<T | null>(null);
const modalRef = passedRef ?? createdRef;

useEffect(() => {
Expand Down
4 changes: 2 additions & 2 deletions client/common/usePrevious.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import { useEffect, useRef } from 'react';
* @param value - The current value to track.
* @returns The previous value before the current render, or undefined if none.
*/
export function usePrevious(value: unknown): unknown | undefined {
const ref = useRef<unknown>();
export function usePrevious<T>(value: T): T | undefined {
const ref = useRef<T>();

useEffect(() => {
ref.current = value;
Expand Down
110 changes: 0 additions & 110 deletions client/components/Dropdown.jsx

This file was deleted.

108 changes: 0 additions & 108 deletions client/components/Dropdown/DropdownMenu.jsx

This file was deleted.

Loading
Loading