feat: pass arg_index to custom completions#6286
Open
feraxhp wants to merge 1 commit intoclap-rs:masterfrom
Open
feat: pass arg_index to custom completions#6286feraxhp wants to merge 1 commit intoclap-rs:masterfrom
feraxhp wants to merge 1 commit intoclap-rs:masterfrom
Conversation
feraxhp
force-pushed
the
feat/complete_at
branch
2 times, most recently
from
6cc0a68 to
eb5377e
Compare
feraxhp
force-pushed
the
feat/complete_at
branch
from
eb5377e to
cf215e5
Compare
epage
reviewed
Feb 27, 2026
| /// | ||
| /// This is useful when predefined value hints are not enough. | ||
| /// Used for complex arg completions sending the arg_index in num_args. | ||
| pub trait PositionalValueCompleter: Send + Sync { |
Member
There was a problem hiding this comment.
What was your reason for going with this design?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple implementation of #6284