clarifyx: added method to annotate signals from admin namespace #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khtufteland
force-pushed
the
kjetil/sol-30-update-go-sdk-to-expose-new-method-adminsignalsannotate
branch
from
5a3a666 to
b63db11
Compare
khtufteland
force-pushed
the
kjetil/sol-30-update-go-sdk-to-expose-new-method-adminsignalsannotate
branch
from
b63db11 to
374914b
Compare
khtufteland
commented
May 8, 2025
khtufteland
force-pushed
the
kjetil/sol-30-update-go-sdk-to-expose-new-method-adminsignalsannotate
branch
from
374914b to
b0060ee
Compare
khtufteland
force-pushed
the
kjetil/sol-30-update-go-sdk-to-expose-new-method-adminsignalsannotate
branch
from
73a17e8 to
a1cfe49
Compare
khtufteland
force-pushed
the
kjetil/sol-30-update-go-sdk-to-expose-new-method-adminsignalsannotate
branch
from
a1cfe49 to
3ffab77
Compare
smyrman
reviewed
May 8, 2025
smyrman
reviewed
May 8, 2025
khtufteland
force-pushed
the
kjetil/sol-30-update-go-sdk-to-expose-new-method-adminsignalsannotate
branch
from
3ffab77 to
2693b2f
Compare
smyrman
reviewed
May 16, 2025
Contributor
smyrman
left a comment
smyrman
left a comment
There was a problem hiding this comment.
This looks good. If I where to nit pick on the commit message, then x (folder name) or clarifyx (package name) might be a better area prefix than xclient, which isn't a name of a package or folder.
Either way, probably good to hold of on merging this until the API reaches production.
khtufteland
force-pushed
the
kjetil/sol-30-update-go-sdk-to-expose-new-method-adminsignalsannotate
branch
from
2693b2f to
f3bb363
Compare
khtufteland
changed the title
khtufteland
force-pushed
the
kjetil/sol-30-update-go-sdk-to-expose-new-method-adminsignalsannotate
branch
from
f3bb363 to
bac0a1a
Compare
khtufteland
force-pushed
the
kjetil/sol-30-update-go-sdk-to-expose-new-method-adminsignalsannotate
branch
from
bac0a1a to
e41497e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.