Add annotateReg
#3091
Open
Add annotateReg
#3091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christiaanb
force-pushed
the
annotate_regs
branch
from
4b22325 to
d74e388
Compare
martijnbastiaan
approved these changes
Nov 21, 2025
Member
martijnbastiaan
left a comment
martijnbastiaan
left a comment
There was a problem hiding this comment.
Cool! Could you open an issue saying termToData should (perhaps) use the evaluator?
Comment on lines
1889
to
1901
| go decls (Attributes ty attrs0:ticks) = do | ||
| tcm <- Lens.view tcCache | ||
| case coreView tcm ty of |
Member
There was a problem hiding this comment.
Could you please add a comment why you're doing this whole block?
Member
Author
There was a problem hiding this comment.
I've added some comments, let me know whether you want me to elaborate it even further
christiaanb
force-pushed
the
annotate_regs
branch
from
d74e388 to
1194408
Compare
a function to add synthesis attributes (e.g. `ASYNC_REG`) to register declarations in the HDL generated by the Clash compiler.
christiaanb
force-pushed
the
annotate_regs
branch
from
1194408 to
bd4aed8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A function to add synthesis attributes (e.g.
ASYNC_REG) to register declarations in the HDL generated by the Clash compiler.The implementation extends the information you can carry around in a
Tick. This made it possible to add attributes to the assigned result of any declaration primitive, which includesregister,delayanddflipflop. It means we didn't have to add any logic to these primitives nor hard-code a list of primitives for which this annotation mechanism works. It also avoid the fragility of the type synonym based approach.