Skip to content

add a link to edit the publications page #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hydrolarus
Copy link
Contributor

Should we maybe make it so that the years are subheadings (##) and find some more descriptive headings, now that there's an extra section?

This is a link to the file and no the /edit/.. link because that one
will bring people to a log-in page if they are not already logged in.

If people are familiar with git/Github enough this should be good.
The Godot documentation does the same.
@hydrolarus hydrolarus force-pushed the publications-edit branch from 19efda6 to 26aedfd Compare May 19, 2025 10:43
@DigitalBrains1
Copy link
Member

@hydrolarus
Copy link
Contributor Author

hydrolarus commented May 20, 2025

@DigitalBrains1 I actually started with that and reverted that, I put the reason in the commit message too.

This is a link to the file and no the /edit/.. link because that one
will bring people to a log-in page if they are not already logged in.

If people are familiar with git/Github enough this should be good.
The Godot documentation does the same.

I'm not 100% sure but I think it also behaves weird if you don't have edit rights on that repository, because you'd have to create a fork first?

EDIT: yes, I just tried that on a repository of a friend where I don't have edit permissions, it brings up a button to fork. But if you're not logged in at all you get a login screen with no other information whatsoever.

I don't know which option is better, knowing Godot only links the file but no the edit link makes me lean towards also doing that 😅

@DigitalBrains1
Copy link
Member

Oops I had forgotten to look at the commit message.

I have no strong opinion either way. (I do think the "Edit" button on GitHub is pretty hard to find.) Since you considered it and decided not to link to the "edit" URL, go ahead and do what you decided is best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants