Skip to content

Embedded json schema #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Apr 24, 2025
Merged

Embedded json schema #139

merged 29 commits into from
Apr 24, 2025

Conversation

Peter9192
Copy link
Member

@Peter9192 Peter9192 commented Apr 22, 2025 •
edited
Loading

Drop config.json, so we only keep the embedded schema.

Closes #135
Merge after #138

Peter9192 added 26 commits April 11, 2025 11:01
@Peter9192
Implement basic zoom; TODO: fix angle in skewT
15b1562
@Peter9192
Add logarithmic zoom for skew-T diagram; TODO: T calculations should …
4b9625c 
…use real axis extent rather than fixes base/top pressure
@Peter9192
Fix skew-T lines responding to original extent instead of actual; now…
89f028b 
… they don't tilt anymore
@Peter9192
Add panning effect, but it is stroboscopic and doesn't work for skewT…
8e29a5a 
… yet
@Peter9192
combine side-effects for both axes in a single callback
53f2cb1
@Peter9192
Merge remote-tracking branch 'origin/main' into pan-zoom
23f4dae
@Peter9192
Remove animationframe
ca46f1f
@Peter9192
Use produce to update both scales in a single call
8be9635
@Peter9192
Don't update panstart; this fixes the jittering
859557b
@Peter9192
Also work in log space
9c32384
@Peter9192
Make consistent for x-direction
d3fae43
@Peter9192
zoom towards cursor
ea696fc
@Peter9192
Add reset plot button
b65f516
@Peter9192
Thinner lines
69e93d4
@Peter9192
Higher resolution plot
1ca0f68
@Peter9192
Round time to steps of 10 minutes
8953c43
@Peter9192
Use runClass from package, skipping BMI altogher + rich metadata for …
0d72ef1 
…output vars; however, app/model hangs on second or third run
@Peter9192
Fix hanging issue: wrap only once...
d072e56
@Peter9192
Make sure initial state is included in output
cd10da8
@Peter9192
Reset pan/zoom when variable changes
f085554
@Peter9192
formatting
202d144
@Peter9192
Use output metadata in plot labels and variable pickers
1e1399a
@Peter9192
ditch BMI
eeb62df
@Peter9192
Fix xlabel in timeseries plot; fix axes extent for non-time on x-axis
8e9dddf
@Peter9192
Remove config.JSON everywhere; only keep the embedded version
638ccfc
@Peter9192
Change units to use superscript
5faf60c
@Peter9192 Peter9192 mentioned this pull request Apr 22, 2025
Closed
@Peter9192 Peter9192 requested a review from sverhoeven April 22, 2025 21:13
@Peter9192 Peter9192 mentioned this pull request Apr 22, 2025
Closed
5 tasks
sverhoeven
sverhoeven approved these changes Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@sverhoeven sverhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, more red than green

Looks like you got to all the places where packages/class/src/config.json was used.

I added pnpx @classmodel/class schema.

Base automatically changed from update-class to main April 24, 2025 13:52
@Peter9192 Peter9192 merged commit 7b0543b into main Apr 24, 2025
4 checks passed
@Peter9192 Peter9192 deleted the embedded-json-schema branch April 24, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverhoeven sverhoeven sverhoeven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deduplicate json schema
2 participants
@Peter9192 @sverhoeven