Skip to content

Fireplume #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 6, 2025
Merged

Fireplume #155

merged 12 commits into from
Jun 6, 2025

Conversation

Peter9192
Copy link
Member

@Peter9192 Peter9192 commented May 28, 2025

Refs #154

  • Adds gridded profiles to class package, uses these in web app (replaces old segment-based profiles)
  • Adds thermodynamics module to class package, replaces current functions in web app
  • If selected variable in profiles is also available in fireplume, displays it in red
  • Fire plume also displayed in thermodynamic plot
  • May need to think about how to display/distinguish fire plumes for multiple experiments

To try it out, you can use this config: fire.json

image

Todo:

  • Add fireplume module in class
  • Add fireplume profiles in plots
  • See if we can refactor the profiles code in analysis.ts a bit more.

@Peter9192 Peter9192 marked this pull request as ready for review June 6, 2025 13:20
@Peter9192 Peter9192 merged commit 0c6d863 into main Jun 6, 2025
4 checks passed
@Peter9192 Peter9192 deleted the fireplume branch June 6, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant