Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit slow path to recent items #457

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Limit slow path to recent items #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d33788f
Log extra details
angrave Jan 26, 2024
d68e773
Created in last 3 montgs
angrave Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion TaskEngine/Tasks/DownloadPlaylistInfoTask.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,19 @@ protected override async Task OnConsume(string playlistId, TaskParameters taskPa
RegisterTask(cleanup, playlistId); // may throw AlreadyInProgress exception
using (var _context = CTDbContext.CreateDbContext())
{
var playlist = await _context.Playlists.FindAsync(playlistId);

var playlist = await _context.Playlists.Include(p=>p.Offering).Where(p=> p.Id == playlistId).FirstOrDefaultAsync();
if (playlist == null)
{
GetLogger().LogError($"Playlist {playlistId} not found");
return;
}
if(playlist.Offering == null || playlist.Offering.CourseName == null)
{
GetLogger().LogError($"Playlist {playlistId} has no associated offering ");
return;
}
GetLogger().LogInformation($"Playlist {playlistId}:<{playlist.Name}>/{playlist.Offering.CourseName}: type=({playlist.SourceType}) unique=({playlist.PlaylistIdentifier})");
int index = 0;
try {
index = 1 + await _context.Medias.Where(m=> m.PlaylistId == playlist.Id).Select(m => m.Index).MaxAsync();
Expand Down Expand Up @@ -82,6 +94,7 @@ protected override async Task OnConsume(string playlistId, TaskParameters taskPa
playlist.ListUpdatedAt = playlist.ListCheckedAt;
}
await _context.SaveChangesAsync();
GetLogger().LogInformation($"Playlist {playlistId}: Task Complete");

}
}
Expand Down
5 changes: 3 additions & 2 deletions TaskEngine/Tasks/QueueAwakerTask.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,18 +198,19 @@ private async Task PendingJobs()
// todoVTTs = await context.Transcriptions.AsNoTracking().Where(
// t => t.Captions.Count > 0 && t.File == null && t.CreatedAt < tooRecentCutoff
// ).OrderByDescending(t => t.CreatedAt).Take(maxVTTs).Select(e => e.Id).ToListAsync();
var last3Months = DateTime.Now.AddMonths(-3);

var maxSceneDetection = 400;
todoSceneDetection = await context.Videos.AsNoTracking().Where(
v=> (v.PhraseHintsDataId== null) && v.PhraseHints == null &&
v.Medias.Any() && v.CreatedAt < tooRecentCutoff
v.Medias.Any() && v.CreatedAt < tooRecentCutoff && v.CreatedAt > last3Months
).OrderByDescending(t => t.CreatedAt).Take(maxSceneDetection).Select(e => e.Id).ToListAsync();

var maxTranscriptions = 40;
todoTranscriptions = await context.Videos.AsNoTracking().Where(
v=> (v.PhraseHintsDataId != null || v.PhraseHints != null) &&
v.TranscribingAttempts < 41 && v.TranscriptionStatus != "NoError" &&
v.Medias.Any() && v.CreatedAt < tooRecentCutoff
v.Medias.Any() && v.CreatedAt < tooRecentCutoff && v.CreatedAt > last3Months
).OrderByDescending(t => t.CreatedAt).Take(maxTranscriptions).Select(e => e.Id).ToListAsync();

// Medias for which no videos have downloaded
Expand Down