Feat/bump dependencies #56
Open
+1,706
−1,939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lmendev
force-pushed
the
feat/upgrade-dependencies
branch
from
1786580 to
fb636bd
Compare
Lmendev
commented
Feb 23, 2024
|
|
||
| const getFilesPath = async pathPattern => await glob(pathPattern) | ||
|
|
||
| return asyncPromisify(getFilesPath)(path.join(dir, pattern)) |
There was a problem hiding this comment.
also we can refactor this function to use async await and avoid asyncPromisify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dependencies are updated in order to use the latest version
Changes Made
By commit
globdependency and createasyncPromisifyto use it in the new wayAdditional Notes
cheerionot updated because next versions are release candidate (RC)