[LLDB][GPU] Add a GPUActions option for sync initialization #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm experimenting with initializating asynchronously and I think it's a good idea to make sync initialization an option in the GPU Actions. Given that AMD was using this by default, I modified it accordingly.
dmpots
approved these changes
Jul 15, 2025
| @@ -190,6 +190,10 @@ struct GPUActions { | |||
| /// Set this to true if the native plug-in sync with the GPU process and wait | |||
| /// for it to return to a running state. | |||
| bool wait_for_gpu_process_to_resume = false; | |||
| /// Set this to true if the native plug-in should wait synchronously for the | |||
| /// GPU process to initialize. This should be true if | |||
| /// `wait_for_gpu_process_to_resume` is set to true as part of initialization. | |||
There was a problem hiding this comment.
Can we add an assert or some error checking to validate the comment here (i.e. that if wait_for_gpu_process_to_resume == true then wait_synchronously_for_gpu_to_initialize == true).
There was a problem hiding this comment.
This should be part of the GPUPluginConnectionInfo structure and should added as:
/// Synchronously wait for the GPU to initialize when connecting.
bool synchronous;
clayborg
requested changes
Jul 15, 2025
| @@ -190,6 +190,10 @@ struct GPUActions { | |||
| /// Set this to true if the native plug-in sync with the GPU process and wait | |||
| /// for it to return to a running state. | |||
| bool wait_for_gpu_process_to_resume = false; | |||
| /// Set this to true if the native plug-in should wait synchronously for the | |||
| /// GPU process to initialize. This should be true if | |||
| /// `wait_for_gpu_process_to_resume` is set to true as part of initialization. | |||
There was a problem hiding this comment.
This should be part of the GPUPluginConnectionInfo structure and should added as:
/// Synchronously wait for the GPU to initialize when connecting.
bool synchronous;
| connection_info.connect_url, GetPluginNameStatic(), debugger, | ||
| *debugger.GetAsyncOutputStream(), gpu_target_sp.get(), error); | ||
| ProcessSP process_sp = | ||
| gpu_action.wait_synchronously_for_gpu_to_initialize |
There was a problem hiding this comment.
Get this bool from connection_info:
connection_info.synchronous ? ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm experimenting with initializating asynchronously and I think it's a good idea to make sync initialization an option in the GPU Actions. Given that AMD was using this by default, I modified it accordingly.