Repository navigation
Pin the CRDs-catalog used by kubeconform - #3169
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 28 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bfd7324 to
56db4d7
Compare
kubeconform fetched CRD schemas from datreeio/CRDs-catalog's main branch, so any change upstream applied to every CI run immediately. The catalog's external-secrets.io update (datreeio/CRDs-catalog#988) shipped SecretStore and ClusterSecretStore schemas that kubeconform cannot compile: its converter treats ESO's new field named `properties` as the schema keyword and writes `additionalProperties: false` into the field list. kubeconform reports this as "could not find schema", which fails Lint on every branch through kubernetes/external-secrets/clusterstore.yaml. Pin the catalog to f1e7f6b, the commit just before datreeio/CRDs-catalog#988, in the kubeconform wrapper and in the upgrade playbook's manual check. The upstream report is datreeio/CRDs-catalog#991; return to main once it is fixed, as tracked in #3168.
56db4d7 to
7bdb171
Compare
1 participant
kubeconform fetched CRD schemas from datreeio/CRDs-catalog's main branch, so any change upstream applied to every CI run immediately. The catalog's external-secrets.io update (datreeio/CRDs-catalog#988) shipped SecretStore and ClusterSecretStore schemas that kubeconform cannot compile: its converter treats ESO's new field named
propertiesas the schema keyword and writesadditionalProperties: falseinto the field list. kubeconform reports this as "could not find schema", which fails Lint on every branch through kubernetes/external-secrets/clusterstore.yaml.Pin the catalog to f1e7f6b, the commit just before datreeio/CRDs-catalog#988, in the kubeconform wrapper and in the upgrade playbook's manual check. The upstream report is datreeio/CRDs-catalog#991; return to main once it is fixed, as tracked in #3168.