Skip to content

Reduce output/ enhance verbosity handling #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 3, 2025

Conversation

saskra
Copy link
Contributor

@saskra saskra commented Feb 7, 2025

Summary

🎯 Purpose: This PR resolves issue #257 by ensuring that verbose=False in Imagelab properly suppresses unnecessary output, including progress bars and the "Reading images from DIRECTORY" message.

📜 Example Usage:
Below is a minimal working example (MWE) demonstrating the fix:

# Necessary Imports:
from cleanvision import Imagelab

print("Running short output test with verbose=True")
# Specify path to folder containing the image files in your dataset
imagelab = Imagelab(data_path="image_files/", verbose=True)
# Automatically check for a predefined list of issues within your dataset
imagelab.find_issues(verbose=True)

print("Running short output test with verbose=False")
# Specify path to folder containing the image files in your dataset
imagelab = Imagelab(data_path="image_files/", verbose=False)
# Automatically check for a predefined list of issues within your dataset
imagelab.find_issues(verbose=False)

Testing

🔍 Testing Done: I ran pytest

@CLAassistant
Copy link

CLAassistant commented Feb 7, 2025

CLA assistant check
All committers have signed the CLA.

@jwmueller jwmueller self-requested a review February 21, 2025 06:37
Copy link
Member

@jwmueller jwmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate your contribution!
Just had quick question about tabnanny and the files (.yml, .txt) that seem like they shouldn't have been part of this PR

@jwmueller
Copy link
Member

Some alerts from CI that need to be fixed. Learn more: https://github.com/cleanlab/cleanvision/blob/main/DEVELOPMENT.md#how-to-style-new-code-contributions

Screenshot 2025-02-20 at 10 40 10 PM

Screenshot 2025-02-20 at 10 40 24 PM

@saskra
Copy link
Contributor Author

saskra commented Feb 21, 2025

Apparently the file deletions only took place after my review request, but now everything should be correct.

@saskra
Copy link
Contributor Author

saskra commented Apr 2, 2025

Hi, is there any progress here?

Copy link
Member

@jwmueller jwmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@jwmueller jwmueller merged commit 135a65d into cleanlab:main Apr 3, 2025
17 of 19 checks passed
@saskra saskra deleted the reduced-output branch April 3, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants