Open
Conversation
ghost
assigned
tamacodechi
suggested changes
Sep 13, 2017
Contributor
tamacodechi
left a comment
tamacodechi
left a comment
There was a problem hiding this comment.
Great 🌮 Just some thoughts ✌️
lib/bill_recognizer.rb
Outdated
| end | ||
|
|
||
| def calculate_amounts | ||
| # First: Remove false positives |
Contributor
There was a problem hiding this comment.
No comment please 🙈
If you want to make it super clear why you have these grouped, then make a separate method that runs these two like
def remove_false_positives
PriceCalculation.remove_quantities
PriceCalculation.remove_dates
endThe code should be so clear that it explains itself without comments 😉
You could also have one method in the price calculation for removing false positives. Seeing as other terms may soon have this too #369 it may be good to have these defined in the calculations and then call the methods from one method before all the calculations. What do you think? 😊
Contributor
|
Also please please the rubocop 🤖 💕 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #370