Fix incorrect history order displaying #579
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not understand the CodeFactor complaint, this change did not implement the bind() method lol |
|
From what I can see, this was most likely flagged because you edited the file, not because of your changes. |
oh, i didn't know that there was this difference you described |
|
@willmatheus there is a bug with the insertion order. The history order is broken. The last calculation I did is in third position. It's very weird. I think that your forget to change the order |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes implemented:
Reversing the order in how the history elements are added to the list.
Reversing the scroll order (backwards) of the recycle view.