Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR continues the package-cleanup effort by splitting
slide2vec.inferenceinto workflow-scoped runtime modules while preserving behavior and current public API usage.Major steps shipped
slide2vec.runtimepackage with:batching.pyhierarchical.pyprogress_bridge.pyserialization.pytypes.pyslide2vec.inferenceto consume these helpers.slide2vec.runtime.distributedfor:slide2vec.inferencefor existing monkeypatch/test patterns.slide2vec.runtime.persistencefor:slide2vec.inference.slide2vec.runtime.tilingfor pure tiling config/backend/archive/coordinate helpers.slide2vec.runtime.embeddingfor metadata + artifact writer helpers.slide2vec/runtime_types.py→slide2vec/runtime/types.py(LoadedModel)slide2vec/model_settings.py→slide2vec/runtime/model_settings.pyslide2vec/registry.py→slide2vec/runtime/registry.pyslide2vec/resources.py→slide2vec/configs/resources.pytests/test_docs.pytests/test_packaging_metadata.pytests/test_batch_collator_timing.pytests/test_output_consistency.pyGuardrails + docs
tests/test_architecture_runtime_split.pydocs/documentation.md.Outcomes
slide2vec.inference.pyreduced from ~3753 lines to ~981 lines.