-
Notifications
You must be signed in to change notification settings - Fork 389
chore(repo): Use node@20 in CI #6848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
WalkthroughUpdates CI configuration to run unit tests on Node.js 20 instead of 18 and adjusts a related comment in the workflow file. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Comment |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/ci.yml (2)
226-231
: Fix misleading cache comment: matrix also runs on Node 22.Comment implies a single “Unit Tests (20)” run name, but this job runs on 20 and 22. Clarify to avoid cache/key confusion.
- # Ensures that all builds are cached appropriately with a consistent run name `Unit Tests (20)`. + # Ensures builds are cached appropriately; run name includes the Node version + # (e.g., `Unit Tests (20)` / `Unit Tests (22)`).
210-213
: LTS lane moved to Node 20 — sweep found many Node 18 references (mostlynode: ">=18.17.0"
) — OK with Node 20; change only if you want to raise the project minimum to >=20.
- Search found engine fields and README prerequisites in root package.json and many packages/templates (packages//package.json, integration/templates//package.json, playground//package.json) and docs (packages//README.md, packages/upgrade/**). pnpm-lock entries reflect dependency engines.
- Action: if you intend to bump the repo minimum to Node 20, update engines and docs (root + packages + templates) and any tool/runtime pins (.nvmrc/.tool-versions); otherwise this CI change is safe to approve.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/ci.yml
(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.github/workflows/*.yml
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
CI/CD must be configured with GitHub Actions.
Files:
.github/workflows/ci.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Formatting | Dedupe | Changeset
- GitHub Check: Build Packages
- GitHub Check: semgrep/ci
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
Description
Node@18 is past the EOL date so switching to Node@20 in CI
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change
Summary by CodeRabbit
Tests
Chores
Notes