Skip to content

Conversation

jacekradko
Copy link
Member

@jacekradko jacekradko commented Sep 24, 2025

Description

Node@18 is past the EOL date so switching to Node@20 in CI

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Tests

    • Updated continuous integration to run unit tests on Node.js 20, aligning automated test coverage with the latest LTS environment.
  • Chores

    • Refreshed workflow labeling/comments to reflect Node.js 20 in test runs.
  • Notes

    • No user-facing changes in this release; these updates improve test infrastructure and consistency across environments.

Copy link

changeset-bot bot commented Sep 24, 2025

⚠️ No Changeset found

Latest commit: 2a81b25

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Sep 24, 2025

Walkthrough

Updates CI configuration to run unit tests on Node.js 20 instead of 18 and adjusts a related comment in the workflow file.

Changes

Cohort / File(s) Summary
CI workflow update
.github/workflows/ci.yml
Bumps unit-tests matrix node-version from 18 to 20; updates initialization step comment to reflect “Unit Tests (20)”.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I thump my paws—version twenty, hooray!
Pipelines hop faster in a shiny new way.
From burrow to build, the carrots align,
Tests nibble on bytes, everything’s fine.
With a twitch of my whiskers, CI’s aglow—
Onward we bound where green checks grow! 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly states the primary change—updating CI to use Node 20—and uses a conventional "chore(repo)" prefix, making it specific, concise, and directly aligned with the PR's content.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/upgrade-node-version-in-ci

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

vercel bot commented Sep 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Ready Ready Preview Comment Sep 24, 2025 3:54pm

Copy link

pkg-pr-new bot commented Sep 24, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6848

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6848

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6848

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6848

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6848

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6848

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6848

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6848

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6848

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6848

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6848

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6848

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6848

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6848

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6848

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6848

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6848

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6848

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6848

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6848

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6848

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6848

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6848

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6848

commit: 2a81b25

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/ci.yml (2)

226-231: Fix misleading cache comment: matrix also runs on Node 22.

Comment implies a single “Unit Tests (20)” run name, but this job runs on 20 and 22. Clarify to avoid cache/key confusion.

-          # Ensures that all builds are cached appropriately with a consistent run name `Unit Tests (20)`.
+          # Ensures builds are cached appropriately; run name includes the Node version
+          # (e.g., `Unit Tests (20)` / `Unit Tests (22)`).

210-213: LTS lane moved to Node 20 — sweep found many Node 18 references (mostly node: ">=18.17.0") — OK with Node 20; change only if you want to raise the project minimum to >=20.

  • Search found engine fields and README prerequisites in root package.json and many packages/templates (packages//package.json, integration/templates//package.json, playground//package.json) and docs (packages//README.md, packages/upgrade/**). pnpm-lock entries reflect dependency engines.
  • Action: if you intend to bump the repo minimum to Node 20, update engines and docs (root + packages + templates) and any tool/runtime pins (.nvmrc/.tool-versions); otherwise this CI change is safe to approve.
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a39f2fc and 2a81b25.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.github/workflows/*.yml

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

CI/CD must be configured with GitHub Actions.

Files:

  • .github/workflows/ci.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants