Skip to content

Fix real-time updates not reflecting product changes until full sync #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
codegen-sh wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix real-time updates not reflecting product changes until full sync #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 83 additions & 10 deletions Model/Api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,17 +132,32 @@ private function getDefaultParams($store_id = null)
public function removeProduct($productId, $store_id = null)
{
try {

// The API might expect a simple array of product IDs, not a JSON string
$params = [
'products' => json_encode([(string) $productId]),
'products' => [(string) $productId],
];

$this->get('product/remove', $params, $store_id);
$this->clerk_logger->log('Removed Product', ['response' => $params]);
// Log the exact parameters being sent for debugging
$this->clerk_logger->log('Removing Product Request', [
'product_id' => $productId,
'store_id' => $store_id,
'params' => $params
]);

$response = $this->get('product/remove', $params, $store_id);

// Log the response for debugging
$this->clerk_logger->log('Removed Product Response', [
'product_id' => $productId,
'response' => $response
]);

} catch (\Exception $e) {

$this->clerk_logger->error('Removing Products Error', ['error' => $e->getMessage()]);
$this->clerk_logger->error('Removing Products Error', [
'product_id' => $productId,
'error' => $e->getMessage()
]);

}
}
Expand Down Expand Up @@ -177,15 +192,58 @@ private function _curl_get($url, $params = [])
$params = is_array($params) ? http_build_query($params) : $params;
$url = $url . '?' . $params;
}

// Log the full URL for debugging
$this->clerk_logger->log('CURL GET Request', [
'url' => $url
]);

$curl = curl_init($url);
curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);

// Add additional options for better error handling
curl_setopt($curl, CURLOPT_FAILONERROR, true);
curl_setopt($curl, CURLOPT_SSL_VERIFYPEER, true);
curl_setopt($curl, CURLOPT_TIMEOUT, 30);

$response = curl_exec($curl);

// Check for curl errors
$curl_error = curl_errno($curl);
if ($curl_error) {
$this->clerk_logger->error('CURL Error', [
'error_code' => $curl_error,
'error_message' => curl_error($curl),
'url' => $url
]);
}

// Get HTTP status code
$http_code = curl_getinfo($curl, CURLINFO_HTTP_CODE);
if ($http_code >= 400) {
$this->clerk_logger->error('HTTP Error', [
'http_code' => $http_code,
'url' => $url,
'response' => $response
]);
}

curl_close($curl);

// Log the response for debugging
$this->clerk_logger->log('CURL GET Response', [
'http_code' => $http_code,
'response' => $response
]);

return $response;

} catch (\Exception $e) {

$this->clerk_logger->error('GET Request Error', ['error' => $e->getMessage()]);
$this->clerk_logger->error('GET Request Error', [
'error' => $e->getMessage(),
'url' => $url
]);

}
}
Expand Down Expand Up @@ -224,15 +282,33 @@ private function get($endpoint, $params = [], $store_id = null)

$params = array_merge($this->getDefaultParams($store_id), $params);

// Log the full request details for debugging
$this->clerk_logger->log('GET Request Details', [
'endpoint' => $endpoint,
'url' => $this->baseurl . $endpoint,
'params' => $params,
'store_id' => $store_id
]);

$url = $this->baseurl . $endpoint;

$response = $this->_curl_get($url, $params);

// Log the response for debugging
$this->clerk_logger->log('GET Response', [
'endpoint' => $endpoint,
'response' => $response
]);

return $response;

} catch (\Exception $e) {

$this->clerk_logger->error('GET Request Error', ['error' => $e->getMessage()]);
$this->clerk_logger->error('GET Request Error', [
'endpoint' => $endpoint,
'error' => $e->getMessage(),
'params' => $params
]);

}
}
Expand Down Expand Up @@ -487,7 +563,4 @@ public function getParametersForEndpoint($endpoint)

return ['limit'];
}



}
14 changes: 14 additions & 0 deletions Observer/ProductSaveAfterObserver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,21 @@ protected function updateStore($product, $storeId)

// check product status, remove if disabled in magento
if ($product->getStatus() == \Magento\Catalog\Model\Product\Attribute\Source\Status::STATUS_DISABLED) {
// Log before attempting to remove the product
$this->logger->info('Product ' . $product->getId() . ' is disabled, attempting to remove from Clerk via real-time update', [
'product_id' => $product->getId(),
'store_id' => $storeId,
'status' => $product->getStatus()
]);

$response = $this->api->removeProduct($product->getId(), $storeId);

// Log after the removal attempt
$this->logger->info('Product removal from Clerk completed', [
'product_id' => $product->getId(),
'store_id' => $storeId
]);

return;
}
//Cancel if product visibility is not as defined
Expand Down