Skip to content

refactor(async): remove fs_event module #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
16bit-ykiko merged 2 commits into from
Jul 5, 2026
Merged

refactor(async): remove fs_event module #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
115f894
refactor(async): remove fs_event module
16bit-ykiko Jul 5, 2026
48ab565
style: format README
16bit-ykiko Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,16 @@ All public APIs live under the `kota::` namespace, public headers under `include
- pipes, TCP sockets, TCP acceptors, console / TTY streams
- UDP sockets with multicast and per-packet send/recv
- Child process API (`process::spawn`) with stdio piping, async wait/kill, and resource-usage reporting.
- Async filesystem API covering the full libuv fs surface (stat / mkdir / scandir / chmod / link / rename / sendfile / utime / mkstemp / …) and filesystem-change notifications via `fs_event`.
- Async filesystem API covering the full libuv fs surface (stat / mkdir / scandir / chmod / link / rename / sendfile / utime / mkstemp / …).
- Libuv watcher wrappers: timer, idle, prepare, check, signal, plus a `sleep` helper.

> **Filesystem-change notifications** are no longer provided. The former `fs_event`
> watcher has been removed — the underlying platform backends proved hard to use and
> unreliable across OSes. For change detection, build a periodic poll on top of the
> existing primitives: a `kota::timer` firing at your desired interval combined with
> `fs::stat` (comparing mtime / size) gives predictable, portable "did this path
> change?" semantics without the platform-specific pitfalls.

- Blocking-work offload via `queue(fn, loop)` onto the libuv thread pool.
- Coroutine-friendly sync primitives: mutex, semaphore, event (with interrupt), and condition variable.
- Error vocabulary: `error` (libuv status wrapper with named codes), `result<T>`, and the general `outcome<T, E, C>`.
Expand Down
1 change: 0 additions & 1 deletion include/kota/async/async.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

#include "kota/support/config.h"
#include "kota/async/io/fs.h"
#include "kota/async/io/fs_event.h"
#include "kota/async/io/loop.h"
#include "kota/async/io/process.h"
#include "kota/async/io/request.h"
Expand Down
71 changes: 0 additions & 71 deletions include/kota/async/io/fs_event.h
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions src/async/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ target_sources(kota_async PRIVATE
"${CMAKE_CURRENT_SOURCE_DIR}/io/system.cpp"
"${CMAKE_CURRENT_SOURCE_DIR}/io/udp.cpp"
"${CMAKE_CURRENT_SOURCE_DIR}/io/watcher.cpp"
"${CMAKE_CURRENT_SOURCE_DIR}/io/fs_event.cpp"
)

target_include_directories(kota_async PUBLIC
Expand All @@ -62,10 +61,4 @@ target_link_libraries(kota_async PUBLIC
libuv::libuv
)

if(APPLE)
target_link_libraries(kota_async PRIVATE
"-framework CoreServices"
)
endif()

kota_apply_project_options(kota_async)
Loading
Loading