Handle Unicode Character/Special Characters in sample sheet. #123
+78
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to VALID ASCII. (403) _encoding changed from utf8 to ISO-8859-1. (489-512) code check for new special charactet not currently present added to VALID ASCII. (733) return also return content variable which is json in real form. First valiable return json in str format. Issue1: special character. Fixes clintval#112
Gaurav basesolve/issue112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the use of 'utf-8' encoding, sample_sheet that has special characters like ã or Ü won't be acceptable by SampleSheet class. We need a way to let the user know that there exist some special character which is not normal and needs to be removed before proceeding further.
Fixes #112