Merge public main into Clio fork #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add on_winner_choose hook
…ontrol When using allow_multiple_experiments=control Split only allows one experiment with an alternative other than 'control'. Split::User#max_experiments_reached? checks for that looping through all experiments. As Split::User#active_experiments drops the experiment version we also need to do that here to be able to check properly. Fixes splitrb#612
…ments-control-with-versions Fix #max_experiments_reached? when using allow_multiple_experiments=control
…bution Replace usage of SimpleRandom with RubyStats
Removed repeated loading from config
…a-when-disabled ab_test must return metadata on error or if split is disabled/excluded user
Introduce enable/disable experiment cohorting
Update Trial so that goals are accessible in callback
…plus Only support Ruby versions >= 2.5
Bump minimum required redis to 4.2
Remove thread_safe config as redis-rb is thread_safe by default since 2.2
Remove redis_url impl. Deprecated on ~2.2
…riment Add ability to initialize experiments
Fix all Layout issues on the project
Enable rubocop on Github Actions
Fix Rubocop Style/* Offenses
Enforce double quotes
Update actions/checkout to v3
robin-phung
commented
Apr 21, 2022
| :override => override_alternative(experiment.name), :exclude => !is_qualified?, | ||
| :disabled => split_generically_disabled?) | ||
| trial = Trial.new(user: ab_user, experiment: experiment, | ||
| override: override_alternative(experiment.name), exclude: exclude_visitor? || !is_qualified?, |
There was a problem hiding this comment.
reintroduce exclude_visitor despite not being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.